[chore] Fix filelog receiver test with new component.ValidateConfig behavior
#37448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Jan 23, 2025
codeboten
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Thanks @evan-bradley, looks like some checks need to be fixed
|
Oh i see, this is merging into a branch... got it |
codeboten
merged commit 65ec900
into
open-telemetry:opentelemetrybot/update-otel-1737650898
145 of 154 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
component.ValidateConfignow validates interfaces. The(*helper.TimeParser).Validatemethod is now called while validatingFileLogConfigand as a result, the struct is modified during validation. The simplest fix seemed to be to apply these same changes to the expected config struct by callingValidateon it, even though the assertion logic in the test now feels a little circular.I can try to refactor the struct a bit to make it more directly testable if desired.
This is needed for #37447.