Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix tests using MetricsLevel #37471

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 24, 2025

Fixes some more issues with the OTel update

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place I could read and understand what's the problem with setting metricslevel?

@mx-psi
Copy link
Member Author

mx-psi commented Jan 24, 2025

Is there a place I could read and understand what's the problem with setting metricslevel?

There was no problem with it before, but we are now getting rid of it since there is now a 'native' replacement in the OTel SDK. See open-telemetry/opentelemetry-collector/issues/11061 and more specifically the PRs listed on open-telemetry/opentelemetry-collector#11061 (comment).

@mx-psi mx-psi merged commit 56d6e19 into open-telemetry:opentelemetrybot/update-otel-1737650898 Jan 24, 2025
9 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants