[chore] Generate replaces automatically in otelcontribcol/oteltestbedcol
#37569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
jade-guiton-dd
force-pushed
the
autogen-ocb-replaces
branch
from
a74db36 to
7ab007a
Compare
mx-psi
reviewed
Jan 30, 2025
mx-psi
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cmd/otelcontribcol/builder-config.yamlcurrently contains numerousreplacesdirectives. These are important for making sure that builds use the local version of the code and not one fetched from the Go proxy, especially during the release process when internal dependencies are set to versions that have not been published yet. To avoid needing to maintain this list of directives manually, this PR removes them frombuilder-config.yamland adds a script which createsbuilder-config-replaced.yamlby appendingreplacesdirectives for every module in the repository. (Some may be superfluous, but that should not cause problems.)Link to tracking issue
Fixes #37243
Testing
I ran the release script locally and no errors occurred in
genotelcontribcolorgentestbedcol.