Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][fileconsumer] Fix flush test #37598

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[chore][fileconsumer] Fix flush test #37598

merged 2 commits into from
Jan 31, 2025

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Jan 30, 2025 •
edited
Loading

This PR adds precision to a test that previously may have succeeding for unreliable reasons.

  • Manage internaltime.Since in addition to internaltime.Now
  • Advance clock intentionally, rather than relying on implied time passage
  • Removes unused Copy function

@djaglowski djaglowski marked this pull request as ready for review January 30, 2025 19:44
@djaglowski djaglowski requested a review from a team as a code owner January 30, 2025 19:44
@djaglowski djaglowski merged commit 4f429e5 into open-telemetry:main Jan 31, 2025
166 of 167 checks passed
@djaglowski djaglowski deleted the fix-flush-test branch January 31, 2025 01:59
@github-actions github-actions bot added this to the next release milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@codeboten codeboten

Labels
pkg/stanza
Projects
None yet
Milestone
v0.119.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djaglowski @atoulme @codeboten