[chore] move package tests from contrib repo to this repo #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowies
changed the title
mowies
changed the title
mx-psi
reviewed
Jul 24, 2024
|
Thanks! |
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add shellcheck option to follow other files Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> use shellcheck directive Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> make shellcheck happy Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix shellcheck things Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> move dockerfiles, remove unneeded files Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> also test rpm package Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add missing variable Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> only build linux amd64 for now Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> only build linux amd64 for now Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix service unit name Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add missing files Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove unneeded variables and files Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add checkout step Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix if conditionals Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add demo config, add script run Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> copy over package test scripts Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add job dependency Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> move package test steps for testing Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> revert goreleaser change Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix if statement Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> test commit Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> run package tests as part of core ci workflow Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> download artifacts in new workflow Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> defuse package tests for now Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> upload linux/amd64 service packages after building a snapshot Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> update goreleaser-pro to latest version, add version field to config files to remove warning Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add package test workflow Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mx-psi
reviewed
Jul 30, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
|
I am going to wait to merge this until after v0.106.1 is released |
This was referenced Aug 1, 2024
6 tasks
andrzej-stencel
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 3, 2024
This PR removes the package tests from this repo since they were moved to the -releases repo in open-telemetry/opentelemetry-collector-releases#604. Related issues: - Original issue: open-telemetry/opentelemetry-collector-releases#439 - Also fixes #34748 Advantages of doing this: - removal of duplicated code that has potential to diverge with linux package building and testing happening here with custom code, but the actual code that is used to build the released linux packages is in the -releases repo. This should result in lower maintenance effort and removes technical debt. Disadvantages discussed here: - bit of a shift-right for the linux package tests since they are now tested in the -releases repo which could lead to situations where bugs are found too late and e.g. the contrib repo already got a new tag which has a bug that only comes up in the releases repo --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
This PR removes the package tests from this repo since they were moved to the -releases repo in open-telemetry/opentelemetry-collector-releases#604. Related issues: - Original issue: open-telemetry/opentelemetry-collector-releases#439 - Also fixes open-telemetry#34748 Advantages of doing this: - removal of duplicated code that has potential to diverge with linux package building and testing happening here with custom code, but the actual code that is used to build the released linux packages is in the -releases repo. This should result in lower maintenance effort and removes technical debt. Disadvantages discussed here: - bit of a shift-right for the linux package tests since they are now tested in the -releases repo which could lead to situations where bugs are found too late and e.g. the contrib repo already got a new tag which has a bug that only comes up in the releases repo --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Eromosele-SM
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
This PR removes the package tests from this repo since they were moved to the -releases repo in open-telemetry/opentelemetry-collector-releases#604. Related issues: - Original issue: open-telemetry/opentelemetry-collector-releases#439 - Also fixes open-telemetry#34748 Advantages of doing this: - removal of duplicated code that has potential to diverge with linux package building and testing happening here with custom code, but the actual code that is used to build the released linux packages is in the -releases repo. This should result in lower maintenance effort and removes technical debt. Disadvantages discussed here: - bit of a shift-right for the linux package tests since they are now tested in the -releases repo which could lead to situations where bugs are found too late and e.g. the contrib repo already got a new tag which has a bug that only comes up in the releases repo --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
fixes some pipelineseparate PR: fix some broken conditionals in pipelines #610ifconditionals that didn't work correctlybumps goreleaser in theseparate PR: update remaining goreleaser usages to v2 #609go.modfile to v2 since that is the version that's used in all pipelines anyways (see e.g. this goreleaser usage)Testing
I tested the new pipelines on my fork's main branch. Fully working runs with the setup from this PR can be seen here:
Core pipeline, Contrib pipeline
Notes
package-tests.shandcommon.shtogether with the test dockerfiles were copied over and slightly adjusted where needed.Testing
I merged this PR into my forked main branch and the pipelines fully work there.
Links to the pipeline runs: Core pipeline, Contrib pipeline
Follow ups
Remove package tests from contrib repo