-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GoReleaser templating to support all collector distros #708
Conversation
@TylerHelmuth I think you've worked with the goreleaser templating recently; would you or someone else mind taking a look? Thanks. |
@open-telemetry/helm-approvers @open-telemetry/operator-approvers appreciate some eyes on this change, thank you |
The templating changes look fine to me, but having them mixed with the PIE changes makes them harder to review. I'd prefer to merge #726 first. I also don't think we should proceed without @TylerHelmuth's review here. |
Agreed, removed those changes. |
Per #716 we do not currently generate the Goreleaser configurations for
otelcol-otlp
andotelcol-k8s
due to different requirements in default files, configurations, builds, etc.This PR adds conditional logic to successfully generate these goreleaser templates.
Anyone can verify this change by downloading "main" branch, applying my changes to
Makefile
andcmd/goreleaser/internal/configure.go
, running$ make generate-goreleaser
and see the minute formatting changes that get applied to the goreleaser templates.The pipeline tests should ensure that these binaries still build and release successfully but of course it should be verified after merge with v0.113.0 or v0.114.0
Updates to the goreleaser template will also likely be required to close #618 so I figured it was a good idea to get all four distros templated first