Skip to content

[chore] add profiles support in receiver builder #10945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Aug 22, 2024

Description

This allows building profiles in the receiver builder.
As this is only changing internal modules, I am marking it as chore (and skipping changelog entry).

Link to tracking issue

#10375

cc @mx-psi

@dmathieu dmathieu changed the title chore: add profiles support in receiver builder [chore] add profiles support in receiver builder Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (2971358) to head (db8e076).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10945      +/-   ##
==========================================
+ Coverage   91.70%   91.74%   +0.04%     
==========================================
  Files         411      411              
  Lines       19292    19305      +13     
==========================================
+ Hits        17692    17712      +20     
+ Misses       1239     1231       -8     
- Partials      361      362       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu force-pushed the profiles-receiver-builder branch from 691b6d4 to 14efeb3 Compare August 22, 2024 14:56
@dmathieu dmathieu marked this pull request as ready for review August 22, 2024 15:10
@dmathieu dmathieu requested review from a team and dmitryax August 22, 2024 15:10
@mx-psi mx-psi added this to the Profiling support milestone Aug 26, 2024
@dmathieu dmathieu force-pushed the profiles-receiver-builder branch from b17a0b2 to e59cddb Compare August 29, 2024 09:07
@dmathieu dmathieu force-pushed the profiles-receiver-builder branch from e59cddb to db8e076 Compare August 29, 2024 09:14
@mx-psi mx-psi merged commit c3ef344 into open-telemetry:main Aug 29, 2024
49 checks passed
@mx-psi
Copy link
Member

mx-psi commented Aug 29, 2024

@dmathieu This caused some conflicts on your other PRs, feel free to resolve conflicts on just one if you want to and ping me on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants