-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[chore] add profiles support in receiver builder #10945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mx-psi
merged 6 commits into
open-telemetry:main
from
dmathieu:profiles-receiver-builder
Aug 29, 2024
Merged
[chore] add profiles support in receiver builder #10945
mx-psi
merged 6 commits into
open-telemetry:main
from
dmathieu:profiles-receiver-builder
Aug 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10945 +/- ##
==========================================
+ Coverage 91.70% 91.74% +0.04%
==========================================
Files 411 411
Lines 19292 19305 +13
==========================================
+ Hits 17692 17712 +20
+ Misses 1239 1231 -8
- Partials 361 362 +1 ☔ View full report in Codecov by Sentry. |
691b6d4
to
14efeb3
Compare
b17a0b2
to
e59cddb
Compare
e59cddb
to
db8e076
Compare
mx-psi
approved these changes
Aug 29, 2024
@dmathieu This caused some conflicts on your other PRs, feel free to resolve conflicts on just one if you want to and ping me on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows building profiles in the receiver builder.
As this is only changing internal modules, I am marking it as chore (and skipping changelog entry).
Link to tracking issue
#10375
cc @mx-psi