-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add githubgen to enhance codeowners and issue templates #11756
[chore] add githubgen to enhance codeowners and issue templates #11756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11756 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 467 467
Lines 25583 25583
=======================================
Hits 23387 23387
Misses 1778 1778
Partials 418 418 ☔ View full report in Codecov by Sentry. |
eeb45e6
to
e969405
Compare
https://github.com/open-telemetry/opentelemetry-go-build-tools/ is probably the right place. Could we just pull the module from contrib (like we do with chloggen) and if we move it update the reference? Referencing it in the |
@evan-bradley that would be possible but I made a few minor changes to the tool to make it work with this repo (e.g. changing the file templates), so that would need to be parameterized in the original tool first to be able to do that. I wanted to do exactly that in a follow up issue afterwards to be able to clearly see what we need to change in the tool to make it general enough to serve both or even more repos in the future. |
I filed open-telemetry/opentelemetry-collector-contrib#36691 to take care of moving githubgen to the build-tools repo |
yes, go-build-tools seems like a better home. |
@mowies Do you think moving to go-build-tools as a first step is doable? I think it's probably less of a hassle than copying the code here |
I'm already working on it :) |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
this is still active |
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
# Conflicts: # internal/tools/go.mod # internal/tools/go.sum
- cmd/mdatagen/internal/samplescraper | ||
- confmap | ||
- connector/forward | ||
- connector/x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be connector/xconnector
, right?
- connector/x | |
- connector/xconnector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is kind of a limitation of the githubgen tool currently. I didn't get around to fix it yet, but I think for now it should be fine. I don't think those components are selected often if at all in the issue templates.
I will merge this in one week if there are no further comments cc @open-telemetry/collector-approvers |
# Conflicts: # exporter/exporterhelper/metadata.yaml
This PR
distributions:
keys in metadata.yaml files (needed for githubgen to work correctly)This change is a prerequisite to be able to ping codeowners reliably with automated tooling as a next step.
Part of #11562