Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that data cannot be accessed after Consume* func is called #12284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 4, 2025

The problem here is that we have components like batchprocessor or others which are keeping a reference of the data and eventually modifying them without any concurrent access protection. Hence, it is required for the callers to not access any data that were passed downstream.

This is not a backwards incompatible change, since pdata is not thread-safe this is a MUST to have here (consider a bug for not being documented) otherwise things will not work in the processing pipelines.

@bogdandrutu bogdandrutu requested review from mx-psi, dmathieu and a team as code owners February 4, 2025 21:36
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (bbe9cb8) to head (b5c9e7b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12284      +/-   ##
==========================================
+ Coverage   91.27%   91.30%   +0.03%     
==========================================
  Files         466      465       -1     
  Lines       25583    25576       -7     
==========================================
+ Hits        23351    23353       +2     
+ Misses       1816     1806      -10     
- Partials      416      417       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants