Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] Add ClientConfig.EnhanceContextWithHeaders #12308

Conversation

jade-guiton-dd
Copy link
Contributor

Description

See related issue for context

Link to tracking issue

Resolves #12307

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.38%. Comparing base (43087bd) to head (92064d1).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
config/configgrpc/configgrpc.go 0.00% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (10.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12308      +/-   ##
==========================================
- Coverage   91.41%   91.38%   -0.04%     
==========================================
  Files         467      467              
  Lines       25583    25584       +1     
==========================================
- Hits        23387    23379       -8     
- Misses       1778     1787       +9     
  Partials      418      418              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jade-guiton-dd
Copy link
Contributor Author

Turns out we can do this without an additional method with grpc.WithUnaryInterceptor, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[configgrpc] Handle gRPC metadata generically
1 participant