Object and enum types should be defined in $defs #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cleanup as we approach stability.
Here I ensure the schema consistently uses JSON schema's schema / subschema options with a new schema modeling rule:
The stylistic consistency part is obvious.
"allow for reuse of concepts" is less obvious. When a type is defined in
$defs
we can reference as many times as needed in properties. When a type is defined directly in a property (or inline if you prefer), that type can only describe the requirements for that single property.This guidance applies to
object
andenum
types. This means that excluded are all primitives and arrays.