Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add document and example for sharing gRPC Client #3260

Merged
merged 2 commits into from
Feb 1, 2025
Merged

[DOC] Add document and example for sharing gRPC Client #3260

merged 2 commits into from
Feb 1, 2025

Conversation

owent
Copy link
Member

@owent owent commented Jan 29, 2025

Changes

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner January 29, 2025 17:44
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 6bc2c4c
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/679c4528eb98f7000805d5b3

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (52a80b5) to head (6bc2c4c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3260   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files         201      201           
  Lines        6385     6385           
=======================================
  Hits         5613     5613           
  Misses        772      772

@owent owent force-pushed the shared_grpc_client branch from 98aea1d to 6bc2c4c Compare January 31, 2025 03:36
marcalff
marcalff approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the doc and example

@marcalff marcalff changed the title Add document and sample for sharing gRPC Client [DOC] Add document and sample for sharing gRPC Client Feb 1, 2025
@marcalff marcalff changed the title [DOC] Add document and sample for sharing gRPC Client [DOC] Add document and example for sharing gRPC Client Feb 1, 2025
@marcalff marcalff merged commit edb8937 into open-telemetry:main Feb 1, 2025
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Feb 2, 2025
@malkia
Merge pull request #170 from open-telemetry/main
9dd4a8c 
[DOC] Add document and example for sharing gRPC Client (open-telemetry#3260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owent @ThomsonTan @lalitb @marcalff