Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Wcf] Add RecordException #2271

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ysolomchenko
Copy link
Contributor

@ysolomchenko ysolomchenko commented Oct 29, 2024

Why?

The WCF instrumentation does not set the exception.stacktrace tag on error spans.

Changes

Add RecordException
WCF instrumentation now sets the exception.stacktrace tag on error spans.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (71655ce) to head (9ac0a1f).
Report is 587 commits behind head on main.

Files with missing lines Patch % Lines
...on.Wcf/Implementation/InstrumentedDuplexChannel.cs 0.00% 4 Missing ⚠️
...n.Wcf/Implementation/InstrumentedRequestChannel.cs 66.66% 2 Missing ⚠️
...Wcf/Implementation/ClientChannelInstrumentation.cs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2271      +/-   ##
==========================================
+ Coverage   73.91%   78.57%   +4.65%     
==========================================
  Files         267       29     -238     
  Lines        9615      700    -8915     
==========================================
- Hits         7107      550    -6557     
+ Misses       2508      150    -2358     
Flag Coverage Δ
unittests-Instrumentation.Wcf 78.57% <46.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...y.Instrumentation.Wcf/WcfInstrumentationOptions.cs 100.00% <100.00%> (ø)
...Wcf/Implementation/ClientChannelInstrumentation.cs 93.50% <50.00%> (-1.30%) ⬇️
...n.Wcf/Implementation/InstrumentedRequestChannel.cs 68.75% <66.66%> (-6.25%) ⬇️
...on.Wcf/Implementation/InstrumentedDuplexChannel.cs 59.75% <0.00%> (ø)

... and 265 files with indirect coverage changes

@ysolomchenko ysolomchenko changed the title [Instrumentation.Wcf] set the exception.stacktrace tag on error spans. [Instrumentation.Wcf] Add RecordException Oct 31, 2024
@ysolomchenko ysolomchenko marked this pull request as ready for review October 31, 2024 09:35
@ysolomchenko ysolomchenko requested a review from a team as a code owner October 31, 2024 09:35
@Kielek
Copy link
Contributor

Kielek commented Oct 31, 2024

Please add some documentation, similar to

{
if (exception != null)
{
activity.RecordException(exception);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extension is being marked Obsolete in 1.10.0. We should call Activity.AddException here. To do that you'll need to wait for the repo to bump to 1.10.0 or you can switch your OTel reference to use OpenTelemetryCoreLatestPrereleaseVersion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better option would be to change it after the bump, along with other libraries where we have record exception

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @CodeBlanch, any other comments here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants