-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Wcf] Add RecordException #2271
base: main
Are you sure you want to change the base?
[Instrumentation.Wcf] Add RecordException #2271
Conversation
…-tag-on-error-spans
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
==========================================
+ Coverage 73.91% 78.57% +4.65%
==========================================
Files 267 29 -238
Lines 9615 700 -8915
==========================================
- Hits 7107 550 -6557
+ Misses 2508 150 -2358
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please add some documentation, similar to opentelemetry-dotnet-contrib/src/OpenTelemetry.Instrumentation.AspNetCore/README.md Line 314 in 72d1030
|
src/OpenTelemetry.Instrumentation.Wcf/WcfInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.Wcf/Implementation/ClientChannelInstrumentation.cs
Outdated
Show resolved
Hide resolved
{ | ||
if (exception != null) | ||
{ | ||
activity.RecordException(exception); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extension is being marked Obsolete
in 1.10.0
. We should call Activity.AddException here. To do that you'll need to wait for the repo to bump to 1.10.0 or you can switch your OTel reference to use OpenTelemetryCoreLatestPrereleaseVersion
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better option would be to change it after the bump, along with other libraries where we have record exception
…-tag-on-error-spans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @CodeBlanch, any other comments here?
Why?
The WCF instrumentation does not set the
exception.stacktrace
tag on error spans.Changes
Add RecordException
WCF instrumentation now sets the
exception.stacktrace
tag on error spans.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes