Skip to content

[SqlClient] Delete redundant unused SqlClient integration test #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

alanwest
Copy link
Member

No CI was configured to run this .NET Framework integration test. We already have another integration test that runs on both .NET and .NET Framework.

@alanwest alanwest requested a review from a team as a code owner June 12, 2025 18:17
@github-actions github-actions bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Jun 12, 2025
@alanwest alanwest merged commit 801976a into open-telemetry:main Jun 17, 2025
61 checks passed
@alanwest alanwest deleted the alanwest/delete-test branch June 17, 2025 21:04
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (71655ce) to head (d7ce250).
Report is 880 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2842       +/-   ##
===========================================
+ Coverage   73.91%   87.60%   +13.69%     
===========================================
  Files         267        9      -258     
  Lines        9615      460     -9155     
===========================================
- Hits         7107      403     -6704     
+ Misses       2508       57     -2451     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 87.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 270 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

thompson-tomo pushed a commit to thompson-tomo/opentelemetry-dotnet-contrib that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants