Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Bump OTelLatestStableVer to 1.9.0 and fix coreunstable test issues #5696

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jun 14, 2024

Relates to #5695

Changes

  • Sets OTelLatestStableVer in Directory.Packages.props to 1.9.0.
  • Switches test projects for coreunstable- packages to use NuGet for core- packages when $(RunningDotNetPack) == true.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team June 14, 2024 22:23
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package labels Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (6250307) to head (7222b20).
Report is 261 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5696      +/-   ##
==========================================
+ Coverage   83.38%   86.13%   +2.74%     
==========================================
  Files         297      254      -43     
  Lines       12531    11054    -1477     
==========================================
- Hits        10449     9521     -928     
+ Misses       2082     1533     -549     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 85.75% <ø> (?)
unittests-Project-Stable 86.01% <ø> (?)
unittests-Solution 86.05% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 84.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 124 files with indirect coverage changes

@CodeBlanch CodeBlanch changed the title [repo] Bump OTelLatestStableVer to 1.9.0 and fix coreunstable test issues. [repo] Bump OTelLatestStableVer to 1.9.0 and fix coreunstable test issues Jun 14, 2024
@CodeBlanch CodeBlanch merged commit 908b46c into open-telemetry:main Jun 14, 2024
52 checks passed
@CodeBlanch CodeBlanch deleted the repo-bump-stable-otel-ver branch June 14, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants