Skip to content

[otlp] Add Log and Mertic Exporter to transmit custom serialized data #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rajkumar-rangaraj
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj commented Nov 14, 2024

Follow up #5969
Design discussion issue #

Changes

Please provide a brief description of the changes here.
Added ProtobufOtlpLogExporter and ProtobufOtlpMetricExporter, which will replace the current OTLP log and metric exporter later.

Next Steps

  • Implement retry and run benchmarks

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner November 14, 2024 23:45
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Nov 14, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 13.18681% with 79 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (6250307) to head (2424417).
Report is 392 commits behind head on main.

Files with missing lines Patch % Lines
...r.OpenTelemetryProtocol/ProtobufOtlpLogExporter.cs 0.00% 40 Missing ⚠️
...penTelemetryProtocol/ProtobufOtlpMetricExporter.cs 0.00% 37 Missing ⚠️
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 66.66% 1 Missing ⚠️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5977      +/-   ##
==========================================
+ Coverage   83.38%   84.57%   +1.18%     
==========================================
  Files         297      271      -26     
  Lines       12531    12355     -176     
==========================================
  Hits        10449    10449              
+ Misses       2082     1906     -176     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 84.52% <13.18%> (?)
unittests-Project-Stable 84.57% <13.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ementation/Serializer/ProtobufOtlpLogSerializer.cs 98.30% <100.00%> (ø)
...ntation/Serializer/ProtobufOtlpMetricSerializer.cs 99.15% <100.00%> (ø)
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 93.58% <66.66%> (+22.52%) ⬆️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 95.45% <66.66%> (-3.56%) ⬇️
...penTelemetryProtocol/ProtobufOtlpMetricExporter.cs 0.00% <0.00%> (ø)
...r.OpenTelemetryProtocol/ProtobufOtlpLogExporter.cs 0.00% <0.00%> (ø)

... and 240 files with indirect coverage changes

@CodeBlanch CodeBlanch changed the title [otlp] Add Log and Mertic Exporter to transmit custom serialized data. [otlp] Add Log and Mertic Exporter to transmit custom serialized data Nov 15, 2024
@CodeBlanch CodeBlanch merged commit 2ae01a7 into open-telemetry:main Nov 15, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants