Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-metrics] Include Meter.Tags in metric identity resolution #5982

Merged
merged 11 commits into from
Dec 26, 2024
Merged

[sdk-metrics] Include Meter.Tags in metric identity resolution #5982

merged 11 commits into from
Dec 26, 2024
+37 −20

Conversation

dulikvor
Copy link
Contributor

@dulikvor dulikvor commented Nov 16, 2024 •
edited
Loading

Fixes #5859
Design discussion issue #

Changes

Metric tags are now considered identifiers, contributing to metric scope uniqueness.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@dulikvor dulikvor requested a review from a team as a code owner November 16, 2024 13:13
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Nov 16, 2024
@dulikvor dulikvor force-pushed the users/dulikvor/markinstrumentation branch from 2458d0b to b5d1011 Compare November 16, 2024 16:51
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (7d7d37a) to head (dba1ae5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5982      +/-   ##
==========================================
- Coverage   86.40%   86.32%   -0.08%     
==========================================
  Files         257      257              
  Lines       11693    11613      -80     
==========================================
- Hits        10103    10025      -78     
+ Misses       1590     1588       -2
Files with missing lines Coverage Δ
src/OpenTelemetry/Metrics/Metric.cs 97.22% <ø> (-0.02%) ⬇️
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs 88.79% <ø> (-0.19%) ⬇️

... and 15 files with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Nov 26, 2024
cijothomas
cijothomas approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please add changelog entry too, as this is breaking existing behavior to fix bug.

@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Nov 27, 2024
@cijothomas cijothomas added the spec-compliance Issues related to compliance with the OpenTelemetry Specification label Dec 4, 2024
@Kielek Kielek requested a review from CodeBlanch December 18, 2024 18:50
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Dec 26, 2024
CodeBlanch
CodeBlanch approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch added the metrics Metrics signal related label Dec 26, 2024
@CodeBlanch CodeBlanch changed the title [bugFix] Meter tags are now recognized as identifiers [sdk-metrics] Include Meter.Tags in metric identity resolution Dec 26, 2024
@CodeBlanch CodeBlanch merged commit 7ae7b13 into open-telemetry:main Dec 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@Kielek Kielek Kielek approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package spec-compliance Issues related to compliance with the OpenTelemetry Specification Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Mark instrumentation scope attributes as identifying
5 participants
@dulikvor @cijothomas @Kielek @rajkumar-rangaraj @CodeBlanch