Skip to content

Conversation

@martincostello
Copy link
Member

Fixes #6410

Changes

Avoid interpolation for workflow scripts and use environment variables instead.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.08%. Comparing base (cfc2d0c) to head (8e61dac).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6865      +/-   ##
==========================================
- Coverage   87.17%   87.08%   -0.10%     
==========================================
  Files         263      263              
  Lines       12385    12385              
==========================================
- Hits        10797    10785      -12     
- Misses       1588     1600      +12     
Flag Coverage Δ
unittests-Project-Experimental 86.97% <ø> (-0.19%) ⬇️
unittests-Project-Stable 86.69% <ø> (-0.36%) ⬇️
unittests-Solution 86.94% <ø> (+0.11%) ⬆️
unittests-UnstableCoreLibraries-Experimental 41.92% <ø> (-47.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

Rename environment variable.
@martincostello martincostello marked this pull request as ready for review January 29, 2026 19:48
@martincostello martincostello requested a review from a team as a code owner January 29, 2026 19:48
Copilot AI review requested due to automatic review settings January 29, 2026 19:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several GitHub Actions workflows to stop using GitHub expression interpolation inside script invocations and instead pass values via environment variables, making scripts easier to lint and run locally while keeping behavior equivalent.

Changes:

  • Updated reusable workflows (verifyaotcompat.yml, concurrency-tests.yml, Component.BuildTest.yml) to pass matrix and input values to PowerShell scripts via environment variables instead of inline ${{ }} interpolation.
  • Adjusted CI integration-test jobs in ci.yml to construct docker-compose file paths using a VERSION environment variable instead of ${{ matrix.version }} directly in the command line.
  • Simplified the automation and labeling workflows (automation.yml, add-labels.yml) to derive control flags and issue/PR numbers from environment variables within the shell, matching the new pattern.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/verifyaotcompat.yml Passes the AOT target framework to test-aot-compatibility.ps1 via TARGET_FRAMEWORK env var instead of positional interpolation.
.github/workflows/concurrency-tests.yml Supplies test project name and target framework to test-threadSafety.ps1 using PROJECT_NAME and TARGET_FRAMEWORK env vars.
.github/workflows/ci.yml Uses a VERSION env var to select the appropriate docker-compose override file for OTLP and W3C trace context integration tests.
.github/workflows/automation.yml Determines whether automation is enabled via an IS_ENABLED env var inside the evaluation step, avoiding expression interpolation in the shell script.
.github/workflows/add-labels.yml Passes issue and PR numbers to the label-management PowerShell module via ISSUE_NUMBER and PR_NUMBER env vars.
.github/workflows/Component.BuildTest.yml Introduces job-level env vars for project name, build commands, and target framework, and consumes them from pwsh-based dotnet restore/build/test steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rajkumar-rangaraj rajkumar-rangaraj added this pull request to the merge queue Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@martincostello
Copy link
Member Author

I think the merge group CI got caught in a GitHub Actions outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[infra] use env. vars. instead of interpolation in build scripts

2 participants