-
Notifications
You must be signed in to change notification settings - Fork 872
[Infra] Avoid interpolation for workflow scripts #6865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6865 +/- ##
==========================================
- Coverage 87.17% 87.08% -0.10%
==========================================
Files 263 263
Lines 12385 12385
==========================================
- Hits 10797 10785 -12
- Misses 1588 1600 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Rename environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates several GitHub Actions workflows to stop using GitHub expression interpolation inside script invocations and instead pass values via environment variables, making scripts easier to lint and run locally while keeping behavior equivalent.
Changes:
- Updated reusable workflows (
verifyaotcompat.yml,concurrency-tests.yml,Component.BuildTest.yml) to pass matrix and input values to PowerShell scripts via environment variables instead of inline${{ }}interpolation. - Adjusted CI integration-test jobs in
ci.ymlto construct docker-compose file paths using aVERSIONenvironment variable instead of${{ matrix.version }}directly in the command line. - Simplified the automation and labeling workflows (
automation.yml,add-labels.yml) to derive control flags and issue/PR numbers from environment variables within the shell, matching the new pattern.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/verifyaotcompat.yml |
Passes the AOT target framework to test-aot-compatibility.ps1 via TARGET_FRAMEWORK env var instead of positional interpolation. |
.github/workflows/concurrency-tests.yml |
Supplies test project name and target framework to test-threadSafety.ps1 using PROJECT_NAME and TARGET_FRAMEWORK env vars. |
.github/workflows/ci.yml |
Uses a VERSION env var to select the appropriate docker-compose override file for OTLP and W3C trace context integration tests. |
.github/workflows/automation.yml |
Determines whether automation is enabled via an IS_ENABLED env var inside the evaluation step, avoiding expression interpolation in the shell script. |
.github/workflows/add-labels.yml |
Passes issue and PR numbers to the label-management PowerShell module via ISSUE_NUMBER and PR_NUMBER env vars. |
.github/workflows/Component.BuildTest.yml |
Introduces job-level env vars for project name, build commands, and target framework, and consumes them from pwsh-based dotnet restore/build/test steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I think the merge group CI got caught in a GitHub Actions outage. |
Fixes #6410
Changes
Avoid interpolation for workflow scripts and use environment variables instead.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)