-
Notifications
You must be signed in to change notification settings - Fork 872
[Examples] Add F# example #6875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6875 +/- ##
==========================================
- Coverage 87.21% 87.19% -0.03%
==========================================
Files 263 263
Lines 12385 12385
==========================================
- Hits 10802 10799 -3
- Misses 1583 1586 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Add an example for an ASP.NET Core application using F#.
Fix Docker Compose configuration for OTLP.
Fix too-long line.
6dbd1b8 to
768ebf1
Compare
baronfel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but I have a couple tiny notes to clean it up a bit.
- Use `task` instead of `async`. - Remove `Literal` attributes.
Changes
Add an example for an ASP.NET Core application using F#.
This was inspired by a conversation @alanwest and myself had at OTel Unplugged with an end-user who wondered why there wasn't an F# SDK for OpenTelemetry.
The example here is based on the AspNetCore example, and then converted with the help of GitHub Copilot. I'm no F# developer, so it might not be as idiomatic as it could be.
While working on this I found some issues with the Docker Compose setup copied from the ASP.NET Core example
so I'm going to park this for now while I fix that#6877.Feedback welcome.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)