Skip to content

Conversation

@martincostello
Copy link
Member

Fixes #6877 (review).

Changes

Remove log scope from ASP.NET Core example.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@martincostello martincostello requested a review from a team as a code owner February 6, 2026 17:45
Copilot AI review requested due to automatic review settings February 6, 2026 17:45
@github-actions github-actions bot added the documentation Documentation related label Feb 6, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unnecessary logging scope from the ASP.NET Core example controller to simplify the sample and avoid adding extra structured scope state to each request.

Changes:

  • Removed per-request BeginScope usage from WeatherForecastController.Get.
  • Deleted the associated LoggerMessage.DefineScope helper from the nested Logger class.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.25%. Comparing base (6180ae3) to head (d13462c).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6880      +/-   ##
==========================================
+ Coverage   87.22%   87.25%   +0.03%     
==========================================
  Files         263      263              
  Lines       12385    12385              
==========================================
+ Hits        10803    10807       +4     
+ Misses       1582     1578       -4     
Flag Coverage Δ
unittests-Project-Experimental 87.06% <ø> (+0.04%) ⬆️
unittests-Project-Stable 87.00% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

@rajkumar-rangaraj rajkumar-rangaraj added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@rajkumar-rangaraj rajkumar-rangaraj added this pull request to the merge queue Feb 9, 2026
Merged via the queue into open-telemetry:main with commit e7da73e Feb 9, 2026
46 checks passed
@martincostello martincostello deleted the remove-example-scope branch February 9, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants