-
Notifications
You must be signed in to change notification settings - Fork 872
[Examples] Remove log scope #6880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples] Remove log scope #6880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes an unnecessary logging scope from the ASP.NET Core example controller to simplify the sample and avoid adding extra structured scope state to each request.
Changes:
- Removed per-request
BeginScopeusage fromWeatherForecastController.Get. - Deleted the associated
LoggerMessage.DefineScopehelper from the nestedLoggerclass.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6880 +/- ##
==========================================
+ Coverage 87.22% 87.25% +0.03%
==========================================
Files 263 263
Lines 12385 12385
==========================================
+ Hits 10803 10807 +4
+ Misses 1582 1578 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixes #6877 (review).
Changes
Remove log scope from ASP.NET Core example.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)