Fix: Observable instruments should not export stale series (#5950) #6883
+303
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to Fix #5950.
Changes
The https://opentelemetry.io/docs/specs/otel/metrics/sdk/#metricreader requires that for asynchronous instruments, MetricReader.Collect MUST only receive data points with measurements recorded since the previous collection. The SDK was instead re-exporting the last known value indefinitely when an observable callback stopped reporting a series.
I seems, the delta temporality path does not have this issue, because of its metric point reclaim mechanism. This PR changes the cumulative path by:
No public API changes. But I'm not sure if the behavior change is considered as API change.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes