improve tests for RestTemplate (#11053)

Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
open-telemetry · Apr 11, 2024 · 2722582 · 2722582
1 parent 0026dda
commit 2722582
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 73 deletions.
diff --git a/...mentation/spring/autoconfigure/instrumentation/web/RestTemplateBeanPostProcessorTest.java b/...mentation/spring/autoconfigure/instrumentation/web/RestTemplateBeanPostProcessorTest.java
diff --git a/...ring/autoconfigure/instrumentation/web/SpringWebInstrumentationAutoConfigurationTest.java b/...ring/autoconfigure/instrumentation/web/SpringWebInstrumentationAutoConfigurationTest.java
@@ -11,26 +11,47 @@
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.autoconfigure.AutoConfigurations;
 import org.springframework.boot.test.context.runner.ApplicationContextRunner;
+import org.springframework.web.client.RestTemplate;
 
 class SpringWebInstrumentationAutoConfigurationTest {
 
   private final ApplicationContextRunner contextRunner =
       new ApplicationContextRunner()
           .withBean(OpenTelemetry.class, OpenTelemetry::noop)
+          .withBean(RestTemplate.class, RestTemplate::new)
           .withConfiguration(
               AutoConfigurations.of(SpringWebInstrumentationAutoConfiguration.class));
 
+  /**
+   * Tests that users create {@link RestTemplate} bean is instrumented.
+   *
+   * <pre>{@code
+   * @Bean public RestTemplate restTemplate() {
+   *     return new RestTemplate();
+   * }
+   * }</pre>
+   */
   @Test
   void instrumentationEnabled() {
     contextRunner
         .withPropertyValues("otel.instrumentation.spring-web.enabled=true")
         .run(
-            context ->
-                assertThat(
-                        context.getBean(
-                            "otelRestTemplateBeanPostProcessor",
-                            RestTemplateBeanPostProcessor.class))
-                    .isNotNull());
+            context -> {
+              assertThat(
+                      context.getBean(
+                          "otelRestTemplateBeanPostProcessor", RestTemplateBeanPostProcessor.class))
+                  .isNotNull();
+
+              assertThat(
+                      context.getBean(RestTemplate.class).getInterceptors().stream()
+                          .filter(
+                              rti ->
+                                  rti.getClass()
+                                      .getName()
+                                      .startsWith("io.opentelemetry.instrumentation"))
+                          .count())
+                  .isEqualTo(1);
+            });
   }
 
   @Test