Enable instrumentation of Spring EJB clients #11104
Conversation
There was a problem hiding this comment.
thanks! is it possible to add a test similar to SpringRmiTest.groovy for this?
|
Sure, I'll see what I can do! |
zackman0010
force-pushed
the
feature/spring_rmi
branch
from
b909af6 to
65d1a15
Compare
|
@trask I was able to write a test for the remote-slsb Spring XML integration pattern. While I was at it, I also converted the Groovy test to Java for #7195. |
zackman0010
force-pushed
the
feature/spring_rmi
branch
from
6d716de to
6546cfd
Compare
The test worked when I ran from IntelliJ, but not when I ran from console. IntelliJ must include all the dependencies on the classpath, so the Spring 6 classes were available there.
The spring-test dependency was only added to use their JNDI mock, but that was removed in Spring 5. With the use of simple-jndi instead, spring-test was no longer required
|
@trask Tests are now successful. Turns out the Spring class I used to mock JNDI was removed in Spring 5, so it broke the latest dependencies test with a NoClassDefFoundError. I replaced it with a different JNDI mock library, it's working now. |
|
Thanks @laurit! I wasn't able to find a way to dynamically create an EJB at runtime, so it's cool to see that you were able to. |
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Spring's XML configuration allows connecting to a remote EJB through the
remote-slsbXML element. This connection utilizes a class in the packageorg.springframework.ejb.access. This PR instruments the required class.