-
Notifications
You must be signed in to change notification settings - Fork 967
make servlet3 + spring webmvc + jaxrs 2.0 indy compatible #12432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
c73f5c6
make servlet3 indy compatible
SylvainJuge 59f857e
spring web mvc
SylvainJuge 7a0993d
wip but still broken
SylvainJuge e6e4f7a
fix clasloading of injected class
SylvainJuge 37970e8
avoid stack overflow with proxy
SylvainJuge cdd978c
spotless
SylvainJuge 30f5356
spotless again
SylvainJuge 4e6ce38
remove debugging exceptions
SylvainJuge dba9e7b
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge dbbbdea
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge b043e83
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 99d8bff
add comment to clarify public field access
SylvainJuge 0c91cbc
turns out proxy delegate access is not needed
SylvainJuge 5b3b408
fix spotless
SylvainJuge d2714ad
public delegate needed with indy
SylvainJuge 978ce81
add a few comments to elaborate on servlet module
SylvainJuge 8740eff
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 43ddd93
post review comment
SylvainJuge da8d9bc
remove indy changes for grails
SylvainJuge affe804
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 54a9f00
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge a7f57cf
better proxy unwrap
SylvainJuge 33c2778
add todo to remove reflection and public field
SylvainJuge 397213f
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 4163047
revert previous impl
SylvainJuge f330abb
another attempt with helper class
SylvainJuge abc58f8
code reformat
SylvainJuge 6d9198b
further simplify caller code
SylvainJuge 5a6683a
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge bceeb00
fix pebkc
SylvainJuge 8708bf7
do not rely on public delegate field
SylvainJuge 59552ab
pebkc printf debug
SylvainJuge 56a52b1
fix test on proxy class
SylvainJuge c468d47
hide IndyProxy interface from reflection
SylvainJuge 20a95bc
indy proxy method impl should be synthetic
SylvainJuge 56f1aa9
update proxy factory test
SylvainJuge c13b72e
add a bit of javadoc
SylvainJuge 63a501e
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 1806c82
test IndyProxyHelper
SylvainJuge 44977f2
spotless
SylvainJuge 37e1823
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 99cc98a
add test for reflection method filtering
SylvainJuge a43b667
also test interface is hidden from reflection
SylvainJuge 1427f9f
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge a5806c6
keep registerHelperResources for inlined
SylvainJuge bf1beca
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
SylvainJuge 9def1a6
IndyProxy > InstrumentationProxy
SylvainJuge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
...reflection/javaagent-integration-tests/src/main/java/instrumentation/TestHelperClass.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package instrumentation; | ||
|
||
/** | ||
* Class that will be injected in target classloader with inline instrumentation and proxied with | ||
* indy instrumentation | ||
*/ | ||
public class TestHelperClass { | ||
|
||
public TestHelperClass() {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.