Convert lettuce 5.1 SyncClientTest from groovy to java #9697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
force-pushed
the
lettuce-5.1-part1
branch
2 times, most recently
from
5214c08 to
af28886
Compare
jaydeluca
force-pushed
the
lettuce-5.1-part1
branch
from
af28886 to
912e3df
Compare
jaydeluca
changed the title
laurit
reviewed
Oct 19, 2023
...testing/src/main/groovy/io/opentelemetry/instrumentation/lettuce/v5_1/LettuceTestUtil.groovy
Show resolved
Hide resolved
laurit
approved these changes
Oct 19, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195
Notes:
LettuceTestUtilwhere I wasn't able to replicate the.protocolVersion(Class.forName("io.lettuce.core.protocol.ProtocolVersion").getField("RESP2").get(null))line (here) as there doesn't seem to be aprotocolVersionmethod on the Builder class in 5.x, which is why I ended up bumping the version in the testing module.