Allow injection of helper bytecode as resources #9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/java-instrumentation-maintainers Please add the |
done 👍 |
laurit
approved these changes
Nov 3, 2023
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/ByteArrayUrl.java
Outdated
Show resolved
Hide resolved
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/ByteArrayUrl.java
Outdated
Show resolved
Hide resolved
Abhishekkr3003
pushed a commit
to Abhishekkr3003/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 7, 2023
FlorianBruckner
added a commit
to 3kraft/opentelemetry-java-instrumentation
that referenced
this pull request
Jan 7, 2025
… classnames are detected. issue open-telemetry#9752 introduced a check that prevents an instrumentation module from being loaded when duplicate helper classes are detected. Such a case may arise when a class is detected by muzzle as a helper class and at the same time it is registered in additionalHelperClasses. Before open-telemetry#9752, the module would properly load. The proposed change will allow the instrumentation to load and log a warning. While it may be true that this is actually an issue in the instrumentation module, such cases are not obvious to find, there are modules in the field that have stopped working because this change and the fix should not lead to unintended behavior as we can expect the bytecode of the duplicates to be identical.
FlorianBruckner
added a commit
to 3kraft/opentelemetry-java-instrumentation
that referenced
this pull request
Jan 9, 2025
… classnames are detected. issue open-telemetry#9752 introduced a check that prevents an instrumentation module from being loaded when duplicate helper classes are detected. Such a case may arise when a class is detected by muzzle as a helper class and at the same time it is registered in additionalHelperClasses. Before open-telemetry#9752, the module would properly load. The proposed change will allow the instrumentation to load and log a warning. While it may be true that this is actually an issue in the instrumentation module, such cases are not obvious to find, there are modules in the field that have stopped working because this change and the fix should not lead to unintended behavior as we can expect the bytecode of the duplicates to be identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to inject the bytecode of proxies as resources. This is required for example for injecting spring-boot autoconfigurations.