Remove conditional requirement on network.peer.address and network.peer.port
#9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
network-peer-update
branch
3 times, most recently
from
3037914 to
f148592
Compare
trask
approved these changes
Oct 30, 2023
...pentelemetry/instrumentation/api/instrumenter/http/ForwardedHostAddressAndPortExtractor.java
Outdated
Show resolved
Hide resolved
|
closing and reopening to rerun checks |
added 2 commits
October 31, 2023 12:44
mateuszrzeszutek
force-pushed
the
network-peer-update
branch
from
f148592 to
5258ece
Compare
laurit
approved these changes
Oct 31, 2023
Abhishekkr3003
pushed a commit
to Abhishekkr3003/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements open-telemetry/semantic-conventions#449