Stable semconv final (?) polishing, JavaDoc updates, minor changes #9815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Nov 7, 2023
trask
approved these changes
Nov 7, 2023
Comment on lines
-116
to
-121
| // TODO: remove this branch? | ||
| String httpRoute = httpRouteGetter.get(context, arg1, arg2); | ||
| if (httpRoute != null && !httpRoute.isEmpty()) { | ||
| // update just the attribute - without http.method we can't compute a proper span name here | ||
| serverSpan.setAttribute(SemanticAttributes.HTTP_ROUTE, httpRoute); | ||
| } |
Abhishekkr3003
pushed a commit
to Abhishekkr3003/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the stable semconv parts for being moved to the main
instrumentation-apimodule (deprecated stuff excluded; I'm gonna start working on that after the Nov release). I think we can say it officially resolves #9785