docs(*): Migrate away from deprecated addSpanProcessor in README
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates from the deprecated `addSpanProcessor` method to the constructor option in preparation for the upcoming SDK 2.0 release. This commit migrates everything in the README.md of each package, other than that there are no runtime code changes. Technically this is a user-facing change for users that previously followed the examples. Ref open-telemetry#2645
github-actions
bot
added
pkg:instrumentation-undici
pkg-status:unmaintained
github-actions
bot
requested review from
blumamir,
david-luna,
dyladan,
legendecas,
martinkuba,
mhennoch and
obecny
github-actions
bot
requested review from
pichlermarc,
pkanal,
t2t2 and
trentm
64 tasks
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
david-luna
approved these changes
Jan 17, 2025
david-luna
changed the title
addSpanProcessor in READMEaddSpanProcessor in README
|
@chancancode I've updated the PR title to pass the lint process. Thanks for your contribution :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2657 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 169 169
Lines 8061 8061
Branches 1646 1646
=======================================
Hits 7319 7319
Misses 742 742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates from the deprecated
addSpanProcessormethod to the constructor option in preparation for the upcoming SDK 2.0 release.This commit migrates everything in the README.md of each package, other than that there are no runtime code changes.
Technically this is a user-facing change for users that previously followed the examples, putting it in its own PR/commit so we can label it for learna-changelog if desired (probably a good idea, in case when it comes time to publishing, this ends up being the only change).
Ref #2645 (cc @pichlermarc)