Skip to content

Commit

Permalink
Global error handler cleanup - Metrics Pipeline (#2244)
Browse files Browse the repository at this point in the history
  • Loading branch information
lalitb authored Oct 27, 2024
1 parent 4a405fd commit 3bc9b3d
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions opentelemetry-sdk/src/metrics/pipeline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ use std::{
};

use opentelemetry::{
global,
metrics::{MetricError, MetricResult},
InstrumentationScope, KeyValue,
otel_debug, InstrumentationScope, KeyValue,
};

use crate::{
Expand Down Expand Up @@ -413,15 +412,18 @@ where
if existing == id {
return;
}

global::handle_error(MetricError::Other(format!(
"duplicate metric stream definitions, names: ({} and {}), descriptions: ({} and {}), kinds: ({:?} and {:?}), units: ({:?} and {:?}), and numbers: ({} and {})",
// If an existing instrument with the same name but different attributes is found,
// log a warning with details about the conflicting metric stream definitions.
otel_debug!(
name: "Instrument.DuplicateMetricStreamDefinitions",
message = "duplicate metric stream definitions",
reason = format!("names: ({} and {}), descriptions: ({} and {}), kinds: ({:?} and {:?}), units: ({:?} and {:?}), and numbers: ({} and {})",
existing.name, id.name,
existing.description, id.description,
existing.kind, id.kind,
existing.unit, id.unit,
existing.number, id.number,
)))
existing.number, id.number,)
);
}
}
}
Expand Down

0 comments on commit 3bc9b3d

Please sign in to comment.