Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print stdout in examples #1212

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

cijothomas
Copy link
Member

I tend to use this a lot, not sure if this we should make the default in examples to do this. This PR adds a comment about how to get pretty print easily.

@cijothomas cijothomas requested a review from a team August 17, 2023 22:02
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can merge it once we get the lint error out of the way

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ba8f9f) 49.1% compared to head (d9b62f5) 49.2%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1212   +/-   ##
=====================================
  Coverage   49.1%   49.2%           
=====================================
  Files        173     173           
  Lines      20937   20937           
=====================================
+ Hits       10301   10302    +1     
+ Misses     10636   10635    -1     
Files Changed Coverage Δ
opentelemetry-sdk/src/runtime.rs 92.1% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas closed this Aug 22, 2023
@cijothomas cijothomas reopened this Aug 22, 2023
@TommyCpp TommyCpp merged commit 2c3017e into open-telemetry:main Aug 23, 2023
12 checks passed
@cijothomas cijothomas deleted the cijothomas/prettyprint branch August 24, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants