Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zpages): use tonic based generated files. #1214

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

TommyCpp
Copy link
Contributor

related to open-telemetry/opentelemetry-rust-contrib#4

Changes

The reason zpages cannot compile after #1202 is prost backed grpcio compiler no longer allow us to add serde macros onto the types. Thus, instead of using grpcio types, use tonic types in zpages fixes it.

Merge requirement checklist

  • [x CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.1% 🎉

Comparison is base (2ba8f9f) 49.1% compared to head (f40a762) 49.3%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   open-telemetry/opentelemetry-rust#1214     +/-   ##
=======================================
+ Coverage   49.1%   49.3%   +0.1%     
=======================================
  Files        173     174      +1     
  Lines      20937   21042    +105     
=======================================
+ Hits       10301   10380     +79     
- Misses     10636   10662     +26     
Files Changed Coverage Δ
opentelemetry-proto/src/transform/tracez.rs 0.0% <ø> (ø)
opentelemetry-sdk/src/runtime.rs 92.1% <ø> (ø)
opentelemetry-zpages/src/trace/aggregator.rs 80.0% <ø> (+0.2%) ⬆️
opentelemetry-zpages/src/trace/mod.rs 0.0% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-cox
Copy link
Contributor

@TommyCpp, I think if you rebase or merge, the CI/docs step will pass. (I'm eager to see this merged as soon as possible so we can merge #1199). Thanks.

The reason zpages cannot compile after open-telemetry#1202 is prost backed grpcio compiler no longer allow us to add `serde` macros onto the types. Thus, instead of using grpcio types, use tonic types in zpages fixes it.
@TommyCpp TommyCpp marked this pull request as ready for review August 23, 2023 15:59
@TommyCpp TommyCpp requested a review from a team August 23, 2023 15:59
@TommyCpp
Copy link
Contributor Author

Waiting for CI to clear and I will merge

@TommyCpp TommyCpp merged commit 3c560d9 into open-telemetry:main Aug 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants