Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create doc/unit tests for SDK MeterProvider #1220

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Aug 22, 2023

Part of #1219

@lzchen lzchen requested a review from a team August 22, 2023 18:47
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 74.5% and project coverage change: +0.1% 🎉

Comparison is base (2ba8f9f) 49.1% compared to head (4c61ae8) 49.3%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1220     +/-   ##
=======================================
+ Coverage   49.1%   49.3%   +0.1%     
=======================================
  Files        173     174      +1     
  Lines      20937   21043    +106     
=======================================
+ Hits       10301   10380     +79     
- Misses     10636   10663     +27     
Files Changed Coverage Δ
opentelemetry-api/src/global/metrics.rs 0.0% <0.0%> (ø)
opentelemetry-sdk/src/metrics/pipeline.rs 56.7% <ø> (ø)
...telemetry-sdk/src/testing/metrics/metric_reader.rs 5.2% <5.2%> (ø)
opentelemetry-sdk/src/metrics/meter_provider.rs 82.3% <96.2%> (+18.4%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TommyCpp TommyCpp merged commit 6f7f8bb into open-telemetry:main Aug 23, 2023
12 checks passed
@lzchen lzchen deleted the mp branch August 23, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants