Disable default features on reqwest #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
=====================================
Coverage 66.0% 66.0%
=====================================
Files 140 140
Lines 19537 19537
=====================================
Hits 12903 12903
Misses 6634 6634 ☔ View full report in Codecov by Sentry. |
|
I think it's duplicated with #1562? |
|
@TommyCpp it is! But its narrower, and it passes CI :) I hadn't seen yours when I put this up. Happy to close it if you prefer. |
TommyCpp
approved these changes
Feb 24, 2024
|
Will rebase #1562 on top of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwest's default features cause openssl to be linked in, and defeats the point
of supporting rustls feature flags. Disable default features to avoid this.
This was a regression from the migration to workspace dep versions.