Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite readme page for opentelemetry crate #1586

Merged

Conversation

cijothomas
Copy link
Member

https://crates.io/crates/opentelemetry The description shown in the crates page is very generic, so this PR is trying to make it crate specific. Not adding examples/getting-started, as it is probably better to stay in docs.rs.

If the direction is good, will fix every other crate (over time...)

@cijothomas cijothomas requested a review from a team February 27, 2024 20:00
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.3%. Comparing base (ef47010) to head (9366794).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1586   +/-   ##
=====================================
  Coverage   67.3%   67.3%           
=====================================
  Files        138     138           
  Lines      19355   19355           
=====================================
  Hits       13029   13029           
  Misses      6326    6326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Small request.

also aligned with the design philosophy of existing telemetry solutions in the
Rust ecosystem, like `tracing` or `log`, where these crates only offer a facade
and the actual functionality is enabled through additional crates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a reference to the registry https://opentelemetry.io/ecosystem/registry/?language=rust for Exporters, Propagator, Instrumentation, and more.
I took the liberty to add the missing elements this morning open-telemetry/opentelemetry.io#4062

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I am going to skip that suggestion in this PR, and add it next. I am still thinking what is the best way to ensure success - simply linking to registry won't necessarily help much unless the user is already familiar with OTel space.
Will come back to this.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nicely done.

@cijothomas cijothomas merged commit eb1a09b into open-telemetry:main Feb 28, 2024
15 checks passed
@cijothomas cijothomas deleted the cijothomas/opentelemetry-readme branch February 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants