-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trace SDK] Send resource once to processor and exporter, and not with every span #1830
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=======================================
- Coverage 74.4% 74.4% -0.1%
=======================================
Files 122 122
Lines 19767 19807 +40
=======================================
+ Hits 14723 14750 +27
- Misses 5044 5057 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks
AFAICT this is now needed because of open-telemetry/opentelemetry-rust#1830 (mentioned in https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/CHANGELOG.md#v0240) Replacing install_batch with install_simple also works.
AFAICT this is now needed because of open-telemetry/opentelemetry-rust#1830 (mentioned in https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/CHANGELOG.md#v0240) Replacing install_batch with install_simple also works.
Fixes #1124
Changes
The changes were done earlier for Logs SDK in #1636 . Creating similar PR for Trace SDK.
Stress test: (~ 12% improvement)
before:
after:
Benchmarks: (~10% improvement):
start-end-span/always-sample:
before: 297.20, after: 269.55
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes