-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix http json example #1835
Fix http json example #1835
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 122 122
Lines 20279 20279
=====================================
+ Hits 15211 15212 +1
+ Misses 5068 5067 -1 ☔ View full report in Codecov by Sentry. |
@lalitb @TommyCpp please take a look at the changes when you get a chance. I had to disable the call to serialize My editor picked up some formatting changes in addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit change. Thanks for the PR.
closing to open a separate PR |
Fixes #1763
Design discussion issue (if applicable) #
Changes
Use string value for event attribute
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes