Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchSpanProcessor to trigger first export after the interval instead of right away #1971

Merged

Conversation

cijothomas
Copy link
Member

Part of #1968
Similar to https://github.com/open-telemetry/opentelemetry-rust/pull/1766/files, this makes similar change to BatchSpanProcessor.

Before the PR:
Exports were triggered at T, T+60, T+120 and so on, where T is the time BSP was built.

With this change:
Exports are triggered at T+60, T+120 and so on, where T is the time BSP was built.

@cijothomas cijothomas requested a review from a team July 27, 2024 01:40
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (4d31408) to head (94d2002).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1971     +/-   ##
=======================================
- Coverage   74.9%   74.9%   -0.1%     
=======================================
  Files        122     122             
  Lines      20403   20404      +1     
=======================================
- Hits       15290   15288      -2     
- Misses      5113    5116      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit cd59346 into open-telemetry:main Jul 27, 2024
25 checks passed
@cijothomas cijothomas deleted the cijothomas/fix-bsp-1st-trigger branch July 27, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants