Global error handler cleanup - MeterProvider #2237
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 121 121
Lines 21113 21117 +4
=======================================
+ Hits 16803 16805 +2
- Misses 4310 4312 +2 ☔ View full report in Codecov by Sentry. |
| message = "Meter provider was already shut down; drop will not attempt shutdown again." | ||
| ); | ||
| } else if let Err(err) = self.shutdown() { | ||
| otel_debug!( |
There was a problem hiding this comment.
This one is a better fit for otel_error, I guess? It's helpful to know if the metrics were not flushed out during the app/meter provider shutdown.
There was a problem hiding this comment.
Yes, deciding between otel_error and otel_debug is challenging in this case—since not all failure errors may be actionable by the user. We can make it more granular later to capture different types of errors and log them separately based on the error type. For now, it’s best to use otel_error, as it's a one-time error during shutdown, and no harm in user knowing even if they can't do anything.
| if self.is_shutdown.load(Ordering::Relaxed) { | ||
| otel_debug!( | ||
| name: "MeterProvider.AlreadyShutdown", | ||
| message = "Meter provider was already shut down; drop will not attempt shutdown again." |
There was a problem hiding this comment.
nit: change semicolon to comma?
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes