-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global error handler cleanup - UpDown Counter, Historgram, Gauge. #2242
Global error handler cleanup - UpDown Counter, Historgram, Gauge. #2242
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
=======================================
- Coverage 79.5% 79.4% -0.1%
=======================================
Files 121 121
Lines 20938 20962 +24
=======================================
Hits 16656 16656
- Misses 4282 4306 +24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let a suggestion about using capital letter for the first letter of each instrument name. That's how we use it in the spec docs as well.
If we go this route, this will need to be updated for the previously merged PRs as well.
Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
Good point. Have updated for all the instruments. |
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes