Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler cleanup - PeriodicReader #2243

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 24, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 24, 2024 23:13
name: "PeriodicReader.Flush.SendResultError",
message = "Failed to send flush result",
reason = format!("{:?}", send_error),
);
Copy link
Member Author

@lalitb lalitb Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't log actual flush error, but failure to send the result status to the channel. So keeping it debug. It would be good to also log the actual flush status as attribute here, but that would need us to clone before it is sent to channel.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.6%. Comparing base (e2db7a0) to head (387c810).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/periodic_reader.rs 18.1% 9 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2243   +/-   ##
=====================================
  Coverage   79.6%   79.6%           
=====================================
  Files        121     121           
  Lines      20918   20916    -2     
=====================================
  Hits       16666   16666           
+ Misses      4252    4250    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit b90c9fb into open-telemetry:main Oct 25, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants