Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler cleanup - Jaeger Remote sampler #2257

Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 28, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 28, 2024 01:12
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.3%. Comparing base (40b1869) to head (788df4e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/trace/sampler/jaeger_remote/sampling_strategy.rs 0.0% 9 Missing ⚠️
...-sdk/src/trace/sampler/jaeger_remote/rate_limit.rs 0.0% 3 Missing ⚠️
...try-sdk/src/trace/sampler/jaeger_remote/sampler.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2257     +/-   ##
=======================================
- Coverage   79.4%   79.3%   -0.1%     
=======================================
  Files        121     121             
  Lines      20961   20968      +7     
=======================================
+ Hits       16646   16648      +2     
- Misses      4315    4320      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb mentioned this pull request Oct 28, 2024
4 tasks
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, but generally good.
(The messages are very detailed and conveys what happened clearly to user. Thanks!)

lalitb and others added 2 commits October 29, 2024 12:02
@lalitb lalitb merged commit a5e2061 into open-telemetry:main Oct 29, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants