-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global error handler cleanup - Jaeger Remote sampler #2257
Global error handler cleanup - Jaeger Remote sampler #2257
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
=======================================
- Coverage 79.4% 79.3% -0.1%
=======================================
Files 121 121
Lines 20961 20968 +7
=======================================
+ Hits 16646 16648 +2
- Misses 4315 4320 +5 ☔ View full report in Codecov by Sentry. |
opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/trace/sampler/jaeger_remote/rate_limit.rs
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/trace/sampler/jaeger_remote/rate_limit.rs
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
…ategy.rs Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
opentelemetry-sdk/src/trace/sampler/jaeger_remote/sampling_strategy.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, but generally good.
(The messages are very detailed and conveys what happened clearly to user. Thanks!)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes