Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: pin url for msrv build #2272

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 4, 2024

Attempt to fix the CI build issue arising from new published url version
servo/rust-url#992

    Checking idna v1.0.3
error[E0658]: use of unstable library feature 'error_in_core'
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/idna-1.0.3/src/lib.rs:78:6
   |
78 | impl core::error::Error for Errors {}
   |      ^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #103765 <https://github.com/rust-lang/rust/issues/103765> for more information

For more information about this error, try `rustc --explain E0658`.

@lalitb lalitb requested a review from a team as a code owner November 4, 2024 18:22
@lalitb
Copy link
Member Author

lalitb commented Nov 4, 2024

Oh, it's not just the msrv failure, the CI will fail for opentelemetry-sdk too for rustc 1.70.0 and jaeger_remote_sampler feature :


labhas@DESKTOP-KNU1IS8:~/obs/ot/lalit/rust/opentelemetry-rust/opentelemetry-sdk$ cargo build --features="jaeger_remote_sampler"
   Compiling smallvec v1.13.2
   Compiling serde v1.0.214
   Compiling form_urlencoded v1.2.1
   Compiling futures-util v0.3.31
   Compiling rand_chacha v0.3.1
   Compiling opentelemetry-http v0.26.0 (/home/labhas/obs/ot/lalit/rust/opentelemetry-rust/opentelemetry-http)
   Compiling icu_normalizer v1.5.0
   Compiling rand v0.8.5
   Compiling idna_adapter v1.2.0
   Compiling idna v1.0.3
error[E0658]: use of unstable library feature 'error_in_core'
  --> /home/labhas/.cargo/registry/src/index.crates.io-6f17d22bba15001f/idna-1.0.3/src/lib.rs:78:6
   |
78 | impl core::error::Error for Errors {}
   |      ^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #103765 <https://github.com/rust-lang/rust/issues/103765> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `idna` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

better to pin the Cargo.toml

@lalitb
Copy link
Member Author

lalitb commented Nov 4, 2024

better to pin the Cargo.toml

done.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (6a079eb) to head (f48cba9).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2272   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        121     121           
  Lines      20981   20981           
=====================================
  Hits       16673   16673           
  Misses      4308    4308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cargo.toml Show resolved Hide resolved
@lalitb lalitb merged commit eca53b2 into open-telemetry:main Nov 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants