Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ValueMap in ExpoHistogram #2282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fraillt
Copy link
Contributor

@fraillt fraillt commented Nov 7, 2024

Fixes #2146

Changes

Refactored ExpoHistogram to use ValueMap for consistency and efficiency.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@fraillt fraillt requested a review from a team as a code owner November 7, 2024 06:57
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (ebf1bb6) to head (e1e82f9).

Files with missing lines Patch % Lines
...-sdk/src/metrics/internal/exponential_histogram.rs 95.8% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2282     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        122     122             
  Lines      20795   20784     -11     
=======================================
- Hits       16514   16503     -11     
  Misses      4281    4281             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply ValueMap for ExpoHistogram metric
1 participant