Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for go.opentelemetry.io switch #5087

Merged
merged 25 commits into from
Aug 27, 2024
Merged

Add blog post for go.opentelemetry.io switch #5087

merged 25 commits into from
Aug 27, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Aug 22, 2024 •
edited by chalin
Loading

@damemi damemi requested a review from a team August 22, 2024 15:39
@damemi damemi mentioned this pull request Aug 22, 2024
Closed
@opentelemetrybot opentelemetrybot requested a review from a team August 22, 2024 15:39
@github-actions github-actions bot added the blog label Aug 22, 2024
@damemi damemi mentioned this pull request Aug 22, 2024
Closed
dmathieu
dmathieu reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we invite folks to reach out synchronously (in a slack channel) if they encounter issues?

content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
@dmathieu dmathieu requested a review from a team August 22, 2024 15:51
chalin
chalin reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments.

content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
mx-psi
mx-psi reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify who is impacted by this change? I guess something like

Downtime would be visible for users of any of the following artifacts: the OpenTelemetry Go language libraries, the OpenTelemetry Collector libraries or the OpenTelemetry Collector Builder

MrAlias
MrAlias reviewed Aug 22, 2024
View reviewed changes
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io-switch.md Outdated Show resolved Hide resolved
@damemi damemi force-pushed the go-opentelemetry-io-switch branch from 8e74e26 to f653299 Compare August 23, 2024 18:04
@opentelemetrybot opentelemetrybot requested a review from a team August 23, 2024 18:04
@damemi
Copy link
Contributor Author

damemi commented Aug 23, 2024

Addressed feedback, please take a look.

Spoke to @austinlparker and @MrAlias and we decided on September 9 to do the DNS switch together over a video call. Happy to invite anyone else who wants to be present to assist.

MrAlias
MrAlias approved these changes Aug 23, 2024
View reviewed changes
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
@damemi
Copy link
Contributor Author

damemi commented Aug 24, 2024

Moved this back to draft while Tyler, Austin and I figure out a time/date that works for all 3 of us

@damemi
Copy link
Contributor Author

damemi commented Aug 26, 2024

Updated the date/time and removed draft. This is ready to merge if there's no more feedback. Thanks!

@damemi damemi force-pushed the go-opentelemetry-io-switch branch from 3ad7ced to 58fe1db Compare August 26, 2024 15:16
tiffany76
tiffany76 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few small changes.

content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
damemi and others added 6 commits August 26, 2024 15:25
@damemi @tiffany76
Update content/en/blog/2024/go-opentelemetry-io.md
15b2ebe 
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@damemi @tiffany76
Update content/en/blog/2024/go-opentelemetry-io.md
829a050 
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@damemi @tiffany76
Update content/en/blog/2024/go-opentelemetry-io.md
28cfbd6 
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@damemi @tiffany76
Update content/en/blog/2024/go-opentelemetry-io.md
4eb6727 
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@damemi @tiffany76
Update content/en/blog/2024/go-opentelemetry-io.md
2446732 
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
@damemi
npm run fix:dict
95282a2
chalin
chalin approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, but LGTM after those are addressed. Thanks!

content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
content/en/blog/2024/go-opentelemetry-io.md Outdated Show resolved Hide resolved
damemi and others added 3 commits August 26, 2024 17:24
@damemi @chalin
Update content/en/blog/2024/go-opentelemetry-io.md
caf6185 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@damemi @chalin
Update content/en/blog/2024/go-opentelemetry-io.md
5606769 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@damemi @chalin
Update content/en/blog/2024/go-opentelemetry-io.md
9d345c0 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@opentelemetrybot opentelemetrybot requested a review from a team August 26, 2024 21:24
damemi and others added 5 commits August 26, 2024 17:24
@damemi @chalin
Update content/en/blog/2024/go-opentelemetry-io.md
9ab12a6 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@damemi @chalin
Update content/en/blog/2024/go-opentelemetry-io.md
a72d5d8 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@damemi
Make list of artifacts bulleted
f4c5850
@damemi
npm prettier --fix
5767c71
@damemi
Fix checks
aa57b2f
@damemi damemi force-pushed the go-opentelemetry-io-switch branch from 3e15cdb to aa57b2f Compare August 26, 2024 22:32
chalin
chalin approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I set the date to 2024-08-27. Will let whoever is the guardian of the blog gate schedule a merge, probably @svrnm or @theletterf.

@theletterf theletterf added this pull request to the merge queue Aug 27, 2024
@theletterf
Copy link
Member

Aaaand it's live!

Merged via the queue into open-telemetry:main with commit 717cf0a Aug 27, 2024
17 checks passed
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
@damemi @tiffany76 @chalin
Add blog post for go.opentelemetry.io switch (open-telemetry#5087)
6dc98d3 
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole left review comments

@tiffany76 tiffany76 tiffany76 approved these changes

@XSAM XSAM XSAM approved these changes

@MrAlias MrAlias MrAlias approved these changes

@mx-psi mx-psi mx-psi approved these changes

@chalin chalin chalin approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
blog
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Blog Post: Announcing Planned Migration for go.opentelemetry.io
9 participants
@damemi @theletterf @dmathieu @dashpole @chalin @mx-psi @MrAlias @XSAM @tiffany76