Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing broken link in architecture.md #5897

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fixing broken link in architecture.md #5897

merged 1 commit into from
Jan 8, 2025

Conversation

ruskipitbull
Copy link
Contributor

Fixing broken link to collector config file.

@ruskipitbull ruskipitbull requested a review from a team as a code owner January 7, 2025 19:18
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 7, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested a review from a team January 7, 2025 19:18
chalin
chalin approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Note to @open-telemetry/docs-maintainers - after the current refresh round of the refcache, I can look into enabling link checking for github.com links. I'll add a note to this effect in a relevant issue.)

@chalin
Copy link
Contributor

chalin commented Jan 7, 2025

Thanks for the link fix @ruskipitbull. You'll need to sign the CLA before we can merge.

@chalin
Copy link
Contributor

chalin commented Jan 7, 2025

@ruskipitbull - is this meant to be a fix to #5896?

@ruskipitbull
Copy link
Contributor Author

@chalin signed the CLA and yes, addressing #5896 .

@svrnm svrnm added this pull request to the merge queue Jan 8, 2025
Merged via the queue into open-telemetry:main with commit 8d5dafb Jan 8, 2025
17 checks passed
@chalin chalin mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
sig:demo
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruskipitbull @chalin @reyang @svrnm