-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Operator] Add docs for instrumenting Deno #5962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TIL that deno comes with otel support, wow! We normally default to not allow documentation for non official otel projects, e.g. we have https://opentelemetry.io/docs/languages/other/ to list 3rd party implementations and language interest (which needs some love and attention from what I just see), but having a language provide out of the box support is very much in line with otel's mission & vision, so we should address that accordingly. @lucacasonato thank you for bringing this to our attention, we need some time to think about that and address this properly. cc @open-telemetry/governance-committee @open-telemetry/technical-committee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the operator perspective, the content looks good to me. I'm also very happy with the runtime having first-party Otel support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyedit pass. See inline suggestions.
Let's keep the sections in alphabetical order: @lucacasonato - could you please move the Go section to be right after the new Deno section? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending @chalin approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oops, I missed that :-/. It does, but the link definition needs to be inside the note. Can you submit a followup PR @lucacasonato? |
Also see open-telemetry/opentelemetry-operator#3613
This adds documentation for using the operator to instrument Deno applications by setting
OTEL_DENO=true
and then injecting withinstrumentation.opentelemetry.io/inject-sdk: "true"
.cc @jaronoff97
Preview: https://deploy-preview-5962--opentelemetry.netlify.app/docs/kubernetes/operator/automatic/#deno