Skip to content

[Operator] Add docs for instrumenting Deno #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

lucacasonato
Copy link
Contributor

@lucacasonato lucacasonato commented Jan 17, 2025

Also see open-telemetry/opentelemetry-operator#3613

This adds documentation for using the operator to instrument Deno applications by setting OTEL_DENO=true and then injecting with instrumentation.opentelemetry.io/inject-sdk: "true".

cc @jaronoff97


Preview: https://deploy-preview-5962--opentelemetry.netlify.app/docs/kubernetes/operator/automatic/#deno

@svrnm
Copy link
Member

svrnm commented Jan 17, 2025

TIL that deno comes with otel support, wow!

We normally default to not allow documentation for non official otel projects, e.g. we have https://opentelemetry.io/docs/languages/other/ to list 3rd party implementations and language interest (which needs some love and attention from what I just see), but having a language provide out of the box support is very much in line with otel's mission & vision, so we should address that accordingly.

@lucacasonato thank you for bringing this to our attention, we need some time to think about that and address this properly.

cc @open-telemetry/governance-committee @open-telemetry/technical-committee

Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the operator perspective, the content looks good to me. I'm also very happy with the runtime having first-party Otel support.

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedit pass. See inline suggestions.

@chalin
Copy link
Contributor

chalin commented Jan 17, 2025

Let's keep the sections in alphabetical order: @lucacasonato - could you please move the Go section to be right after the new Deno section?

@opentelemetrybot opentelemetrybot requested a review from a team January 19, 2025 16:36
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @chalin approval

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin added this pull request to the merge queue Jan 20, 2025
Merged via the queue into open-telemetry:main with commit 732d683 Jan 20, 2025
17 checks passed
@lucacasonato lucacasonato deleted the operator_deno_docs branch January 20, 2025 16:36
@lucacasonato
Copy link
Contributor Author

Thanks folks.

It looks like the static site generator does not support links inside of "notes":

image

@chalin
Copy link
Contributor

chalin commented Jan 20, 2025

Oops, I missed that :-/. It does, but the link definition needs to be inside the note. Can you submit a followup PR @lucacasonato?

@lucacasonato
Copy link
Contributor Author

#5993

@svrnm svrnm mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants