-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daily semconv check #5980
Add daily semconv check #5980
Conversation
@trask you may want to check the prettier check locally and update the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool.
I get the feeling that this workflow would be best kept in the semconv repo. WDYT?
I'm not sure how to run the docs workflow from the semconv repo (maybe could submodule it in?) |
@svrnm once mentioned that it is possible to reference/call workflows from other repos. Is that right? |
yeah, what I didn't consider though is that the (semconv) workflow could directly check out the docs repo (no need to submodule), I'll try this out, thanks! |
I think the problem is this:
I do think we could copy I guess I see this as an integration test for the website repo, and so it doesn't seem that out-of-place to live in the website repo. Maybe a better option instead of opening the issue in semconv repo is to open the issue in the website repo but tag the semconv maintainers on it? |
Ok, given all that, I'd be opening to having the workflow run in this repo. I'd rather have the issue created in |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879013379 |
fix:format failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879013379. |
Our bot doesn't have the permission to push updates to your workflow files:
@trask, you should update from |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879782312 |
fix:format failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879782312. |
|
Replaced by #5996 |
new plan, I'm going to move the yml file out of workflows, then |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879883331 |
fix:format failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879883331. |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12879900677 |
IMPORTANT: (RE-)RUN
|
f3f1f31
to
1c64b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a try. I'm thinking that we might want to trigger on commits to semconv main
instead of a daily cron job, but we can tweak that later if needed.
😅 ... a lot of work, but it did the trick! 🙌🏻 Next time maybe consider locally (and temporarily) replacing
Right, we don't officially support builds from Windows. I've wanted to work on this in the past but I don't have a Windows environment to test from 🤷🏼♂️. |
this worked! thanks |
Runs
build-dev.yml
once a day and opens an issue in the semantic convention repository on failure.cc @open-telemetry/specs-semconv-approvers