-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enduser domain and add enduser.pseudo.id
#1456
base: main
Are you sure you want to change the base?
Conversation
0a8b0e8
to
ee0970f
Compare
enduser.authentication.id
…s/semantic-conventions into heya/add-enduser-namespace
For people who are flip-flopping on what we discussed about sub namespace #1104 (comment) or watch the SIG meeting recordings whenever i was present :) |
hi @heyams, I don't see any arguments in those links for specifically preferring in order to help this PR move forward, can you write out the reasons you have for specifically preferring |
it was decided in the SIG meeting, not me. recording is available though. they preferred to have |
@heyams I still don't see any reasons in your last comment for specifically preferring |
hey @heyams it might be a long thread but I think we all want to see it merged. I remember we have discussed in the beginning that it might be good to have additional sub namespace for please let me know if it would work for you |
I was planning to attend the SIG to get everyone's feedback. Monday was a public holiday here. If that was the consensus from everyone from the SIG to reuse enduser.id for the authenticated user id, I'm good with it. I can go ahead to make a change this week and then discuss it further in the next SIG if anyone else objects. i appreciate that you reach out because this sub-namespace was your original idea. |
hey @heyams - sure, back then we wanted to find a solution on how to manage both auth and not auth id, and that was one of ideas, but now we have already |
enduser.authentication.id
enduser.pseudo.id
@heyams there are still conflicts not resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided comments offline about possible rewording of the description for enduser.pseudo.id
specifically to remove the "reveal" wording. But this would be a refinement and not a blocker.
@joaopgrassi i don't have permission to dismiss your "request for change". Your comment no longer applied. |
Fixes #1104