-
Notifications
You must be signed in to change notification settings - Fork 244
Add k8s Pod volume metrics #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Do you think it would make sense to consistently use |
If I understand the suggestion correctly, it seems that free/available would still be useful/needed? From https://pkg.go.dev/k8s.io/kubelet@v0.33.0/pkg/apis/stats/v1alpha1#FsStats:
|
ah, right |
However, based on this I think it makes sense to record also the |
968b769
to
ad1dfbd
Compare
Would it be possible to add a |
It's done: 5459577 |
aac5ffb
to
4e87084
Compare
4e87084
to
fa23af3
Compare
f1406f6
to
bfe9ddb
Compare
bfe9ddb
to
8e7c4f8
Compare
@dashpole your comments should be addressed now, please take another look when you get the chance. |
93dfc7b
to
e34483e
Compare
@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers please take a look |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
e34483e
to
f64c9fd
Compare
Fixes #1485
Changes
This PR adds
k8s.pod.volume.*
metrics:Collector ref: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.127.0/receiver/kubeletstatsreceiver/documentation.md#k8svolumeavailable
Collector implementation: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.127.0/receiver/kubeletstatsreceiver/internal/kubelet/volume.go#L16
These metrics are derived from the VolumeStats field of the PodStats of the Kubelet's stats API.
Note: The current implementation reports them as
k8s.volume.*
but I think they should bek8s.pod.volume.*
to better indicate the scope since there is no concept a K8s Volume outside of the Pod context.Attributes for volume types that are deprecated are not added here: open-telemetry/opentelemetry-collector-contrib#40477
Merge requirement checklist
[chore]